Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112984/
-----------------------------------------------------------

(Updated Oct. 1, 2013, 8:45 p.m.)


Review request for KDE Frameworks.


Changes
-------

Add KEMOTICONS_DEPRECATED


Repository: kdelibs


Description
-------

Adjust API in KEmoticons framework: KEmoticonsProvider::save()

-To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save()
and prefer saveTheme() instead.
-Adjust plugins.
-Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(),
which was empty. Now it's a pure virtual function. Therefore, I deprecate
it and advice subclassing KEmoticonsProvider.


Diffs (updated)
-----

  staging/kemoticons/src/core/kemoticonsprovider.h 85fc7ef 
  staging/kemoticons/src/core/kemoticonstheme.h b8b25f7 
  staging/kemoticons/src/core/kemoticonstheme.cpp ed3407c 
  staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267 
  staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0f 
  staging/kemoticons/src/providers/kde/kde_emoticons.h 8cba6b1 
  staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 70bafa3 
  staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89ee 
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 0873a63 
  staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed 

Diff: http://git.reviewboard.kde.org/r/112984/diff/


Testing
-------

It builds. It installs. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131001/65b8bb8d/attachment-0001.html>