<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112984/">http://git.reviewboard.kde.org/r/112984/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Oct. 1, 2013, 8:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add KEMOTICONS_DEPRECATED</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adjust API in KEmoticons framework: KEmoticonsProvider::save()
-To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save()
and prefer saveTheme() instead.
-Adjust plugins.
-Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(),
which was empty. Now it's a pure virtual function. Therefore, I deprecate
it and advice subclassing KEmoticonsProvider.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds. It installs. Tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kemoticons/src/core/kemoticonsprovider.h <span style="color: grey">(85fc7ef)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.h <span style="color: grey">(b8b25f7)</span></li>
<li>staging/kemoticons/src/core/kemoticonstheme.cpp <span style="color: grey">(ed3407c)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.h <span style="color: grey">(039a267)</span></li>
<li>staging/kemoticons/src/providers/adium/adium_emoticons.cpp <span style="color: grey">(a3aaa0f)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.h <span style="color: grey">(8cba6b1)</span></li>
<li>staging/kemoticons/src/providers/kde/kde_emoticons.cpp <span style="color: grey">(5b5114a)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h <span style="color: grey">(70bafa3)</span></li>
<li>staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp <span style="color: grey">(e9f89ee)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h <span style="color: grey">(0873a63)</span></li>
<li>staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp <span style="color: grey">(0dc92ed)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112984/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>