Review Request 113685: New KColorSchemeManager to support changing color scheme in app

Martin Gräßlin mgraesslin at kde.org
Thu Nov 14 05:50:31 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/
-----------------------------------------------------------

(Updated Nov. 14, 2013, 6:50 a.m.)


Review request for KDE Frameworks, Albert Astals Cid, Gilles Caulier, and Boudewijn Rempt.


Changes
-------

fixed the issues


Repository: kdelibs


Description
-------

This class is inspired by functionality offered by e.g. Krita and
Digikam to allow the user to select a different color scheme for the
application.
    
This manager simplifies this task and also ensures that the required
property on QApplication is set, so that a QStyle can pass the scheme
to the window manager/compositor for the windows of the application.

@boud and @cgilles: please have a look whether this approach is sufficient for your usecases in digkam and Krita.


Diffs (updated)
-----

  tier3/kconfigwidgets/tests/kcolorschemedemo.cpp PRE-CREATION 
  tier3/kconfigwidgets/src/CMakeLists.txt 36ffca8 
  tier3/kconfigwidgets/src/kcolorschememanager.h PRE-CREATION 
  tier3/kconfigwidgets/src/kcolorschememanager.cpp PRE-CREATION 
  tier3/kconfigwidgets/src/kcolorschememanager_p.h PRE-CREATION 
  tier3/kconfigwidgets/tests/CMakeLists.txt f66dc32 

Diff: http://git.reviewboard.kde.org/r/113685/diff/


Testing
-------

see demo application


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131114/df6738fa/attachment.html>


More information about the Kde-frameworks-devel mailing list