Review Request 113685: New KColorSchemeManager to support changing color scheme in app

[Kevin Ottens]

> On Nov. 13, 2013, 4:41 p.m., David Faure wrote:
> > tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 93
> > <http://git.reviewboard.kde.org/r/113685/diff/2/?file=212585#file212585line93>
> >
> >     this is still a C++11 initializer list, which isn't in the wiki page of allowed C++11 constructs in KF5, is it?
> 
> Martin Gräßlin wrote:
>     according to Wikipedia this is valid C++03 code. See https://en.wikipedia.org/wiki/C%2B%2B11#Initializer_lists

Yep, it's a good old struct so that's fine.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43607
-----------------------------------------------------------


On Nov. 12, 2013, 8:48 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113685/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 8:48 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Gilles Caulier, and Boudewijn Rempt.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This class is inspired by functionality offered by e.g. Krita and
> Digikam to allow the user to select a different color scheme for the
> application.
>     
> This manager simplifies this task and also ensures that the required
> property on QApplication is set, so that a QStyle can pass the scheme
> to the window manager/compositor for the windows of the application.
> 
> @boud and @cgilles: please have a look whether this approach is sufficient for your usecases in digkam and Krita.
> 
> 
> Diffs
> -----
> 
>   tier3/kconfigwidgets/src/CMakeLists.txt 36ffca8 
>   tier3/kconfigwidgets/src/kcolorschememanager.h PRE-CREATION 
>   tier3/kconfigwidgets/src/kcolorschememanager.cpp PRE-CREATION 
>   tier3/kconfigwidgets/src/kcolorschememanager_p.h PRE-CREATION 
>   tier3/kconfigwidgets/tests/CMakeLists.txt f66dc32 
>   tier3/kconfigwidgets/tests/kcolorschemedemo.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113685/diff/
> 
> 
> Testing
> -------
> 
> see demo application
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131113/e217c9d4/attachment-0001.html>