Review Request 113827: CMake: refer to target directly instead of getting LOCATION property
Commit Hook
null at kde.org
Thu Nov 14 00:05:22 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113827/#review43643
-----------------------------------------------------------
This review has been submitted with commit c28742fbfebb98582b9c1cc68b0c5914ad3180d4 by Alex Merry to branch frameworks.
- Commit Hook
On Nov. 12, 2013, 10:29 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113827/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 10:29 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> CMake: refer to target directly instead of getting LOCATION property
>
> This silences an annoying CMake warning.
>
>
> Diffs
> -----
>
> tier3/kdewidgets/src/CMakeLists.txt b376db89543aa4097045beabe9596eee0800e825
>
> Diff: http://git.reviewboard.kde.org/r/113827/diff/
>
>
> Testing
> -------
>
> Re-running cmake no longer has the warning. After removing kdewidgets.cpp from the build directory and running make, it is regenerated correctly.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131114/cc4994f5/attachment.html>
More information about the Kde-frameworks-devel
mailing list