Review Request 113827: CMake: refer to target directly instead of getting LOCATION property
Kevin Ottens
ervin at kde.org
Wed Nov 13 20:49:37 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113827/#review43631
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On Nov. 12, 2013, 10:29 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113827/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 10:29 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> CMake: refer to target directly instead of getting LOCATION property
>
> This silences an annoying CMake warning.
>
>
> Diffs
> -----
>
> tier3/kdewidgets/src/CMakeLists.txt b376db89543aa4097045beabe9596eee0800e825
>
> Diff: http://git.reviewboard.kde.org/r/113827/diff/
>
>
> Testing
> -------
>
> Re-running cmake no longer has the warning. After removing kdewidgets.cpp from the build directory and running make, it is regenerated correctly.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131113/71acff67/attachment.html>
More information about the Kde-frameworks-devel
mailing list