Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Nov 11 03:23:11 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113723/
-----------------------------------------------------------
(Updated Nov. 11, 2013, 3:23 a.m.)
Review request for KDE Frameworks.
Changes
-------
updated following (some of) david's comments.
Repository: kdelibs
Description
-------
As you will see, this splitting was a bit harder than others:
- KIO was using a couple of private headers from kjobwidgets, which now they will be installed.
- The xslt_kde target was being used from KDocTools without having it exported. Now it will be properly exported.
- Also defines all dependencies so it can be compiled independently, modularization is done as well.
Diffs (updated)
-----
staging/kio/src/ioslaves/help/CMakeLists.txt 40637dc
staging/kio/src/filewidgets/CMakeLists.txt 31fe8c6
staging/kio/CMakeLists.txt 6c7297e
cmake/modules/FindGSSAPI.cmake
cmake/modules/CMakeLists.txt 07f7eac
staging/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt 2630f01
staging/kio/src/ioslaves/http/tests/CMakeLists.txt 52c9f6c
staging/kio/src/widgets/CMakeLists.txt d90386d
staging/kio/src/widgets/kopenwithdialog.cpp cb4fc0f
staging/kio/tests/CMakeLists.txt 6cee291
superbuild/CMakeLists.txt 53f5952
tier1/kcoreaddons/src/lib/CMakeLists.txt 4e6e206
tier1/kcoreaddons/src/lib/jobs/kcompositejob_p.h 20baf7c
tier2/kdoctools/CMakeLists.txt c2256ff
tier2/kdoctools/KDocToolsConfig.cmake d501dc8
tier2/kdoctools/KDocToolsConfig.cmake.in PRE-CREATION
tier2/kdoctools/src/CMakeLists.txt 3940e98
tier3/kded/KDEDConfig.cmake.in 32f8d56
Diff: http://git.reviewboard.kde.org/r/113723/diff/
Testing
-------
Builds, Installs, tests still pass; both modularized and monolithic kdelibs.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131111/324ee125/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list