<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113723/">http://git.reviewboard.kde.org/r/113723/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2013, 3:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">updated following (some of) david's comments.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As you will see, this splitting was a bit harder than others:
- KIO was using a couple of private headers from kjobwidgets, which now they will be installed.
- The xslt_kde target was being used from KDocTools without having it exported. Now it will be properly exported.
- Also defines all dependencies so it can be compiled independently, modularization is done as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, Installs, tests still pass; both modularized and monolithic kdelibs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kio/src/ioslaves/help/CMakeLists.txt <span style="color: grey">(40637dc)</span></li>
<li>staging/kio/src/filewidgets/CMakeLists.txt <span style="color: grey">(31fe8c6)</span></li>
<li>staging/kio/CMakeLists.txt <span style="color: grey">(6c7297e)</span></li>
<li>cmake/modules/FindGSSAPI.cmake <span style="color: grey">()</span></li>
<li>cmake/modules/CMakeLists.txt <span style="color: grey">(07f7eac)</span></li>
<li>staging/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: grey">(2630f01)</span></li>
<li>staging/kio/src/ioslaves/http/tests/CMakeLists.txt <span style="color: grey">(52c9f6c)</span></li>
<li>staging/kio/src/widgets/CMakeLists.txt <span style="color: grey">(d90386d)</span></li>
<li>staging/kio/src/widgets/kopenwithdialog.cpp <span style="color: grey">(cb4fc0f)</span></li>
<li>staging/kio/tests/CMakeLists.txt <span style="color: grey">(6cee291)</span></li>
<li>superbuild/CMakeLists.txt <span style="color: grey">(53f5952)</span></li>
<li>tier1/kcoreaddons/src/lib/CMakeLists.txt <span style="color: grey">(4e6e206)</span></li>
<li>tier1/kcoreaddons/src/lib/jobs/kcompositejob_p.h <span style="color: grey">(20baf7c)</span></li>
<li>tier2/kdoctools/CMakeLists.txt <span style="color: grey">(c2256ff)</span></li>
<li>tier2/kdoctools/KDocToolsConfig.cmake <span style="color: grey">(d501dc8)</span></li>
<li>tier2/kdoctools/KDocToolsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier2/kdoctools/src/CMakeLists.txt <span style="color: grey">(3940e98)</span></li>
<li>tier3/kded/KDEDConfig.cmake.in <span style="color: grey">(32f8d56)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113723/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>