Review Request 113657: Fix Standalone Configuration of DNSSD

Commit Hook null at kde.org
Mon Nov 11 00:25:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113657/#review43396
-----------------------------------------------------------


This review has been submitted with commit 39e87ae731a0972f3dbc532f1832527582551a00 by David E. Narvaez to branch frameworks.

- Commit Hook


On Nov. 11, 2013, 12:21 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113657/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 12:21 a.m.)
> 
> 
> Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 7910270 
>   cmake/modules/FindAvahi.cmake  
>   cmake/modules/FindDNSSD.cmake 8604bd5 
>   tier2/dnssd/CMakeLists.txt 2cfcc40 
> 
> Diff: http://git.reviewboard.kde.org/r/113657/diff/
> 
> 
> Testing
> -------
> 
> 1. Configure with cmake
> 2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1
> 
> Configures OK in both cases. Builds OK in case 1, does not build yet in case 2.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131111/934cb812/attachment.html>


More information about the Kde-frameworks-devel mailing list