Review Request 113657: Fix Standalone Configuration of DNSSD

David Narváez david.narvaez at computer.org
Mon Nov 11 00:21:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113657/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 12:21 a.m.)


Review request for KDE Frameworks, Kevin Ottens, Aurélien Gâteau, and Stephen Kelly.


Changes
-------

Fixing the issue raised about KF5_VERSION


Repository: kdelibs


Description
-------

Moved FindAvahi.cmake and FindDNSSD.cmake into KDNSSD, fixed details when building with DNSSD and factored out the Frameworks version.


Diffs (updated)
-----

  cmake/modules/CMakeLists.txt 7910270 
  cmake/modules/FindAvahi.cmake  
  cmake/modules/FindDNSSD.cmake 8604bd5 
  tier2/dnssd/CMakeLists.txt 2cfcc40 

Diff: http://git.reviewboard.kde.org/r/113657/diff/


Testing
-------

1. Configure with cmake
2. Configure with cmake and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1

Configures OK in both cases. Builds OK in case 1, does not build yet in case 2.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131111/e5499ee3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list