Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

[Àlex Fiestas]

> On Nov. 2, 2013, 1:42 p.m., Alex Merry wrote:
> > tier2/kjobwidgets/src/kdialogjobuidelegate.cpp, line 79
> > <http://git.reviewboard.kde.org/r/113516/diff/1/?file=206575#file206575line79>
> >
> >     This will be application model, I believe.  Might be worth mentioning the class apidocs (and/or providing a way to make it window-modal instead).

I have documented it, adding new api would be outside the scope of this review.


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113516/#review42831
-----------------------------------------------------------


On Nov. 5, 2013, 11:04 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113516/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2013, 11:04 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Implement queueing directly in KDialogJobUiDelegate by queueing calls to KDialogJobUiDelegate::Private::next which shows 1 KMessageBox at the time.
> 
> 
> Diffs
> -----
> 
>   tier2/kjobwidgets/src/kdialogjobuidelegate.h 5d17a4d 
>   tier2/kjobwidgets/src/kdialogjobuidelegate.cpp 29c2bae 
>   tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 
> 
> Diff: http://git.reviewboard.kde.org/r/113516/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131105/4c1d1a47/attachment.html>