Review Request 113522: Improve documentation in ECMInstallIcons.cmake

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113522/#review42834
-----------------------------------------------------------

Ship it!


Looks good, modulo the comments below.


modules/ECMInstallIcons.cmake
<http://git.reviewboard.kde.org/r/113522/#comment30985>

    Add a note that any file not in this format, or with unrecognized components, will be ignored?  Although, actually, it seems unknown groups will be replaced with "actions".



modules/ECMInstallIcons.cmake
<http://git.reviewboard.kde.org/r/113522/#comment30984>

    Reading the cmake code, it looks like it should be "sc" for svgz files.


- Alex Merry


On Oct. 31, 2013, 5:07 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113522/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 5:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
>     Improve documentation in ECMInstallIcons.cmake
> 
> 
> Diffs
> -----
> 
>   modules/ECMInstallIcons.cmake 1114805 
> 
> Diff: http://git.reviewboard.kde.org/r/113522/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131102/f8ad8052/attachment.html>