Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

[Martin Klapetek]

> On Nov. 4, 2013, 4:54 p.m., Commit Hook wrote:
> > This review has been submitted with commit 1e1b33ea862bcbcfdf24a769f36bfcc672bc0f02 by Martin Klapetek to branch frameworks.
> 
> Christoph Feck wrote:
>     For whatever reason, it still installs "libKPty.so.SOVERSION", instead of "libKPty.so.5.0.0".

Thanks, fixed in 1dc07dd54a895916e0319697c544b93113b2ddba.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113601/#review42975
-----------------------------------------------------------


On Nov. 4, 2013, 4:54 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113601/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 4:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> While installing frameworks I noticed some of them have .SOVERSION instead of real version appended. This sets proper SO version in respective cmake files and libs now have proper .5.0.0 suffix.
> 
> 
> Diffs
> -----
> 
>   tier3/kemoticons/src/core/CMakeLists.txt d25a863 
>   tier3/knewstuff/src/CMakeLists.txt dd5c69a 
>   tier3/kprintutils/src/CMakeLists.txt b7ce265 
>   tier3/kpty/src/CMakeLists.txt 4948dcc 
>   tier3/kross/src/core/CMakeLists.txt d66f273 
>   tier3/kross/src/qts/CMakeLists.txt b25adee 
>   tier3/kross/src/ui/CMakeLists.txt 9736ec0 
>   tier4/kcmutils/src/CMakeLists.txt e0a87be 
> 
> Diff: http://git.reviewboard.kde.org/r/113601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131105/0c9989d8/attachment.html>