<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113601/">http://git.reviewboard.kde.org/r/113601/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 4th, 2013, 4:54 p.m. UTC, <b>Commit Hook</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1e1b33ea862bcbcfdf24a769f36bfcc672bc0f02 by Martin Klapetek to branch frameworks.</pre>
</blockquote>
<p>On November 5th, 2013, 10:43 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For whatever reason, it still installs "libKPty.so.SOVERSION", instead of "libKPty.so.5.0.0".</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, fixed in 1dc07dd54a895916e0319697c544b93113b2ddba.</pre>
<br />
<p>- Martin</p>
<br />
<p>On November 4th, 2013, 4:54 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 4, 2013, 4:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While installing frameworks I noticed some of them have .SOVERSION instead of real version appended. This sets proper SO version in respective cmake files and libs now have proper .5.0.0 suffix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/kemoticons/src/core/CMakeLists.txt <span style="color: grey">(d25a863)</span></li>
<li>tier3/knewstuff/src/CMakeLists.txt <span style="color: grey">(dd5c69a)</span></li>
<li>tier3/kprintutils/src/CMakeLists.txt <span style="color: grey">(b7ce265)</span></li>
<li>tier3/kpty/src/CMakeLists.txt <span style="color: grey">(4948dcc)</span></li>
<li>tier3/kross/src/core/CMakeLists.txt <span style="color: grey">(d66f273)</span></li>
<li>tier3/kross/src/qts/CMakeLists.txt <span style="color: grey">(b25adee)</span></li>
<li>tier3/kross/src/ui/CMakeLists.txt <span style="color: grey">(9736ec0)</span></li>
<li>tier4/kcmutils/src/CMakeLists.txt <span style="color: grey">(e0a87be)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113601/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>