Review Request 110646: Move kfontutils to KGUIAddons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110646/#review33294
-----------------------------------------------------------

Ship it!


Looks good. I was a bit surprised that nothing uses this within kdelibs, but after looking at it, it's a bit special case (not utils for the font dialog or something) and lxr says that it's used in kdegames and kdeedu. So it's all fine.


- David Faure


On May 25, 2013, 4:44 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110646/
> -----------------------------------------------------------
> 
> (Updated May 25, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Description
> -------
> 
> move kdeui/fonts/kfontutil -> staging/kguiaddons/src/fonts
> 
> It appears 'git mv' doesn't should up in the diff
> 
> #       renamed:    kdeui/fonts/kfontutils.cpp -> staging/kguiaddons/src/fonts/kfontutils.cpp
> #       renamed:    kdeui/fonts/kfontutils.h -> staging/kguiaddons/src/fonts/kfontutils.h
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt dcbcb4f 
>   staging/kguiaddons/src/CMakeLists.txt 1e7e3a0 
>   staging/kguiaddons/src/fonts/kfontutils.h d23b8bd 
> 
> Diff: http://git.reviewboard.kde.org/r/110646/diff/
> 
> 
> Testing
> -------
> 
> build - no tests for this 
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130528/8a6f16b6/attachment-0001.html>