<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110646/">http://git.reviewboard.kde.org/r/110646/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. I was a bit surprised that nothing uses this within kdelibs, but after looking at it, it's a bit special case (not utils for the font dialog or something) and lxr says that it's used in kdegames and kdeedu. So it's all fine.
</pre>
<br />
<p>- David</p>
<br />
<p>On May 25th, 2013, 4:44 p.m. UTC, Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated May 25, 2013, 4:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move kdeui/fonts/kfontutil -> staging/kguiaddons/src/fonts
It appears 'git mv' doesn't should up in the diff
# renamed: kdeui/fonts/kfontutils.cpp -> staging/kguiaddons/src/fonts/kfontutils.cpp
# renamed: kdeui/fonts/kfontutils.h -> staging/kguiaddons/src/fonts/kfontutils.h
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build - no tests for this </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(dcbcb4f)</span></li>
<li>staging/kguiaddons/src/CMakeLists.txt <span style="color: grey">(1e7e3a0)</span></li>
<li>staging/kguiaddons/src/fonts/kfontutils.h <span style="color: grey">(d23b8bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110646/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>