Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

[David Faure]

> On May 28, 2013, 9 a.m., David Gil Oliva wrote:
> > kdeui/dialogs/kpassworddialog.cpp, line 69
> > <http://git.reviewboard.kde.org/r/110643/diff/1/?file=146196#file146196line69>
> >
> >     Is QLatin1String better than QStringLiteral? I'm still trying to find out...
> >     
> >     http://doc-snapshot.qt-project.org/qt5-dev/qtcore/qstring.html#QStringLiteral
> >     
> >     http://thread.gmane.org/gmane.comp.lib.qt.devel/990/focus=1005
> >     
> >     http://woboq.com/blog/qstringliteral.html
> >     
> >     http://www.macieira.org/blog/2011/07/qstring-improved/

I didn't read your full litterature, but as I understand it: this is a case where a conversion to QString will happen anyway (that's what fromTheme takes as input), so QStringLiteral is the best tool for the job.

In case of comparisons it could be different (I'm not sure which one is best then), but for this case it seems pretty clear to me.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110643/#review33268
-----------------------------------------------------------


On May 25, 2013, 12:57 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110643/
> -----------------------------------------------------------
> 
> (Updated May 25, 2013, 12:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Known "bugs"
>  - there's no clear icon in the text field anymore as I had to port away from KLineEdit
> 
> Diff shown is without the actual moving for easier reviewing.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt cfa29ef 
>   kdeui/dialogs/kpassworddialog.h e554c2a 
>   kdeui/dialogs/kpassworddialog.cpp 168271c 
>   kdeui/dialogs/kpassworddialog.ui 95845b9 
>   kdeui/tests/CMakeLists.txt cd055d5 
>   kdeui/tests/kpassworddialogtest.cpp b1c55ee 
>   tier1/kwidgetsaddons/src/CMakeLists.txt df22699 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4 
> 
> Diff: http://git.reviewboard.kde.org/r/110643/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130528/be4940dc/attachment.html>