Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110643/#review33268
-----------------------------------------------------------



kdeui/dialogs/kpassworddialog.cpp
<http://git.reviewboard.kde.org/r/110643/#comment24610>

    Is QLatin1String better than QStringLiteral? I'm still trying to find out...
    
    http://doc-snapshot.qt-project.org/qt5-dev/qtcore/qstring.html#QStringLiteral
    
    http://thread.gmane.org/gmane.comp.lib.qt.devel/990/focus=1005
    
    http://woboq.com/blog/qstringliteral.html
    
    http://www.macieira.org/blog/2011/07/qstring-improved/


- David Gil Oliva


On May 25, 2013, 12:57 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110643/
> -----------------------------------------------------------
> 
> (Updated May 25, 2013, 12:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Known "bugs"
>  - there's no clear icon in the text field anymore as I had to port away from KLineEdit
> 
> Diff shown is without the actual moving for easier reviewing.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt cfa29ef 
>   kdeui/dialogs/kpassworddialog.h e554c2a 
>   kdeui/dialogs/kpassworddialog.cpp 168271c 
>   kdeui/dialogs/kpassworddialog.ui 95845b9 
>   kdeui/tests/CMakeLists.txt cd055d5 
>   kdeui/tests/kpassworddialogtest.cpp b1c55ee 
>   tier1/kwidgetsaddons/src/CMakeLists.txt df22699 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4 
> 
> Diff: http://git.reviewboard.kde.org/r/110643/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130528/611d9523/attachment.html>