Review Request 110457: Move kdatetimewidget to kde4attic

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110457/#review32623
-----------------------------------------------------------



kdeui/dialogs/kconfigdialogmanager.cpp
<http://git.reviewboard.kde.org/r/110457/#comment24270>

    Please revert that part, it is done via introspection so no dependency problem if we keep it. It'll be in fact harmful to ported code which would still use KDateTimeWidget as this widget has no well known base class in Qt (unlike previous patch by annma for KTextBrowser which inherited QTextBrowser).


- Kevin Ottens


On May 15, 2013, 6:35 p.m., wojtas k9 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110457/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 6:35 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Move kdatetimewidget to kde4attic
> 
> Note: In kconfigdialogmanager.cpp s_changedMap there is QDateTimeEdit so we don't losing features
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 1497e3f 
>   kdeui/dialogs/kconfigdialogmanager.cpp 405799b 
>   kdeui/tests/CMakeLists.txt 9a6cab9 
>   kdeui/tests/kdatetimewidgettest.cpp d4e15e7 
>   kdeui/widgets/kdatetimewidget.h eecf564 
>   kdeui/widgets/kdatetimewidget.cpp f2032d1 
>   staging/kde4attic/src/CMakeLists.txt e3811fc 
>   staging/kde4attic/src/kdatetimewidget.h PRE-CREATION 
>   staging/kde4attic/src/kdatetimewidget.cpp PRE-CREATION 
>   staging/kde4attic/tests/CMakeLists.txt 1305d63 
>   staging/kde4attic/tests/kdatetimewidgettest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110457/diff/
> 
> 
> Testing
> -------
> 
> It builds
> 
> 
> Thanks,
> 
> wojtas k9
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130516/86d24e45/attachment-0001.html>