<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110457/">http://git.reviewboard.kde.org/r/110457/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110457/diff/1/?file=144099#file144099line136" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kconfigdialogmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KConfigDialogManager::initMaps()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">136</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">s_changedMap</span><span class="p">()</span><span class="o">-></span><span class="n">insert</span><span class="p">(</span> <span class="s">"KDateTimeWidget"</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">valueChanged</span><span class="p">(</span><span class="n">QDateTime</span><span class="p">)));</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please revert that part, it is done via introspection so no dependency problem if we keep it. It'll be in fact harmful to ported code which would still use KDateTimeWidget as this widget has no well known base class in Qt (unlike previous patch by annma for KTextBrowser which inherited QTextBrowser).</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On May 15th, 2013, 6:35 p.m. UTC, wojtas k9 wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By wojtas k9.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 6:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move kdatetimewidget to kde4attic
Note: In kconfigdialogmanager.cpp s_changedMap there is QDateTimeEdit so we don't losing features</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(1497e3f)</span></li>
<li>kdeui/dialogs/kconfigdialogmanager.cpp <span style="color: grey">(405799b)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(9a6cab9)</span></li>
<li>kdeui/tests/kdatetimewidgettest.cpp <span style="color: grey">(d4e15e7)</span></li>
<li>kdeui/widgets/kdatetimewidget.h <span style="color: grey">(eecf564)</span></li>
<li>kdeui/widgets/kdatetimewidget.cpp <span style="color: grey">(f2032d1)</span></li>
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(e3811fc)</span></li>
<li>staging/kde4attic/src/kdatetimewidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4attic/src/kdatetimewidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4attic/tests/CMakeLists.txt <span style="color: grey">(1305d63)</span></li>
<li>staging/kde4attic/tests/kdatetimewidgettest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110457/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>