Review Request 110434: Prepare KFontRequester for move to KWidgetAddons

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110434/#review32572
-----------------------------------------------------------


OK, I understand better the confusion. No one was using that class in kdelibs. By two commits what I generally mean is: remove the dependencies from the other classes toward that one in a different commit, then make a commit which moves the class and make the smaller adjustment for that. Here you're going for even finer grained. :-)

It's ok of course even though it wasn't what I had in mind.


kdeui/fonts/kfontrequester.cpp
<http://git.reviewboard.kde.org/r/110434/#comment24244>

    fromUtf8 ? Not that it matters much in that case.


- Kevin Ottens


On May 15, 2013, 12:48 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110434/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 12:48 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Prepare KFontRequester for move to KWidgetAddons
> 
> 
> Diffs
> -----
> 
>   kdeui/fonts/kfontrequester.h c59aeaa 
>   kdeui/fonts/kfontrequester.cpp 68c5c1a 
> 
> Diff: http://git.reviewboard.kde.org/r/110434/diff/
> 
> 
> Testing
> -------
> 
> Compiled.
> No test available. Will create a simple loader when moving to the tier1 folder.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130515/a0225e6e/attachment-0001.html>