<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110434/">http://git.reviewboard.kde.org/r/110434/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, I understand better the confusion. No one was using that class in kdelibs. By two commits what I generally mean is: remove the dependencies from the other classes toward that one in a different commit, then make a commit which moves the class and make the smaller adjustment for that. Here you're going for even finer grained. :-)
It's ok of course even though it wasn't what I had in mind.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110434/diff/2/?file=143891#file143891line210" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/fonts/kfontrequester.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KFontRequester::KFontRequesterPrivate::_k_buttonClicked()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">208</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_sampleLabel</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span> <span class="n">QString</span><span class="p">(</span> <span class="s">"%1 %2"</span> <span class="p">).</span><span class="n">arg</span><span class="p">(</span> <span class="n">family</span> <span class="p">).</span><span class="n">arg</span><span class="p">(</span> <span class="n"><span class="hl">KLocale</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">global</span></span><span class="p"><span class="hl">()</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">formatNumber</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="n"><span class="hl">size</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="n">size</span> <span class="o"><span class="hl">==</span></span><span class="hl"> </span><span class="n"><span class="hl">floor</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">size</span></span><span class="p"><span class="hl">))</span></span><span class="hl"> </span><span class="o"><span class="hl">?</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="hl"> </span><span class="o"><span class="hl">:</span></span><span class="hl"> </span><span class="mi"><span class="hl">1</span></span><span class="hl"> </span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">208</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_sampleLabel</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span> <span class="n">QString</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLatin1</span></span><span class="p">(</span> <span class="s">"%1 %2"</span> <span class="p">).</span><span class="n">arg</span><span class="p">(</span> <span class="n">family</span> <span class="p">).</span><span class="n">arg</span><span class="p">(</span> <span class="n">size</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fromUtf8 ? Not that it matters much in that case.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On May 15th, 2013, 12:48 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 12:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prepare KFontRequester for move to KWidgetAddons</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled.
No test available. Will create a simple loader when moving to the tier1 folder.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/fonts/kfontrequester.h <span style="color: grey">(c59aeaa)</span></li>
<li>kdeui/fonts/kfontrequester.cpp <span style="color: grey">(68c5c1a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110434/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>