Review Request 110434: Prepare KFontRequester for move to KWidgetAddons

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110434/
-----------------------------------------------------------

(Updated May 15, 2013, 12:48 p.m.)


Review request for KDE Frameworks.


Changes
-------

Fixed a bug made by an earlier change KFontDialog -> QFontDialog which ended up with us not saving the font.

QFontDialog does not allow setting fractional font sizes in the UI (i.e 5.6) whereas KFontDialog did. I don't know if this is a known "regression". 

Question for future porting:
I was told by Kevin to submit for review before moving, as otherwise reviewboard can't show the diff properly (which makes a lot of sense). However it's hard to spot all the changes that are needed before moving.

I ended up moving to tier1, changing things + building + testing, then moving back to the original location to make the diff. Is this a sane/correct workflow? 


Description
-------

Prepare KFontRequester for move to KWidgetAddons


Diffs (updated)
-----

  kdeui/fonts/kfontrequester.h c59aeaa 
  kdeui/fonts/kfontrequester.cpp 68c5c1a 

Diff: http://git.reviewboard.kde.org/r/110434/diff/


Testing
-------

Compiled.
No test available. Will create a simple loader when moving to the tier1 folder.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130515/ead783ef/attachment.html>