Review Request 110437: Move KTextBrowser to KDE4Support

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110437/#review32546
-----------------------------------------------------------

Ship it!


Bonus point if you in fact did two commits locally (one for the porting to QTextBrowser part, one for the class move).

Nice job like the previous ones, you definitely got that rolling now. :-)

- Kevin Ottens


On May 15, 2013, 9:37 a.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110437/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 9:37 a.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Replace KTextBrowser with QTextBrowser, move KTextBrowser to KDE4Support, move test as well.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt db4c1d5 
>   kdeui/dialogs/kaboutapplicationdialog.cpp bf0c9de 
>   kdeui/dialogs/kconfigdialogmanager.cpp 620f0b5 
>   kdeui/dialogs/ktip.cpp 3ea2dca 
>   kdeui/shortcuts/kcheckaccelerators.cpp 612c90d 
>   kdeui/tests/CMakeLists.txt d0c8b42 
>   kdeui/tests/ktextbrowsertest.cpp 606886c 
>   kdeui/widgets/kcharselect.cpp 2e43d0d 
>   kdeui/widgets/ktextbrowser.h 71aa7e7 
>   kdeui/widgets/ktextbrowser.cpp 37918c0 
>   kdewidgets/kde.widgets 6ccdcb65 
>   kdewidgets/kdedeprecated.qrc 6152a80 
>   kdewidgets/kdedeprecated.widgets cda6929 
>   kdewidgets/kdewidgets.qrc 0a741e5 
>   staging/kde4support/src/CMakeLists.txt 354a278 
>   staging/kde4support/src/kdeui/ktextbrowser.h PRE-CREATION 
>   staging/kde4support/src/kdeui/ktextbrowser.cpp PRE-CREATION 
>   staging/kde4support/tests/CMakeLists.txt e3e42ba 
>   staging/kde4support/tests/ktextbrowsertest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110437/diff/
> 
> 
> Testing
> -------
> 
> It builds
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130515/bb4f5567/attachment.html>