<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110437/">http://git.reviewboard.kde.org/r/110437/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bonus point if you in fact did two commits locally (one for the porting to QTextBrowser part, one for the class move).
Nice job like the previous ones, you definitely got that rolling now. :-)</pre>
<br />
<p>- Kevin</p>
<br />
<p>On May 15th, 2013, 9:37 a.m. UTC, Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Kevin Ottens.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 9:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replace KTextBrowser with QTextBrowser, move KTextBrowser to KDE4Support, move test as well.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(db4c1d5)</span></li>
<li>kdeui/dialogs/kaboutapplicationdialog.cpp <span style="color: grey">(bf0c9de)</span></li>
<li>kdeui/dialogs/kconfigdialogmanager.cpp <span style="color: grey">(620f0b5)</span></li>
<li>kdeui/dialogs/ktip.cpp <span style="color: grey">(3ea2dca)</span></li>
<li>kdeui/shortcuts/kcheckaccelerators.cpp <span style="color: grey">(612c90d)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(d0c8b42)</span></li>
<li>kdeui/tests/ktextbrowsertest.cpp <span style="color: grey">(606886c)</span></li>
<li>kdeui/widgets/kcharselect.cpp <span style="color: grey">(2e43d0d)</span></li>
<li>kdeui/widgets/ktextbrowser.h <span style="color: grey">(71aa7e7)</span></li>
<li>kdeui/widgets/ktextbrowser.cpp <span style="color: grey">(37918c0)</span></li>
<li>kdewidgets/kde.widgets <span style="color: grey">(6ccdcb65)</span></li>
<li>kdewidgets/kdedeprecated.qrc <span style="color: grey">(6152a80)</span></li>
<li>kdewidgets/kdedeprecated.widgets <span style="color: grey">(cda6929)</span></li>
<li>kdewidgets/kdewidgets.qrc <span style="color: grey">(0a741e5)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(354a278)</span></li>
<li>staging/kde4support/src/kdeui/ktextbrowser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/ktextbrowser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/tests/CMakeLists.txt <span style="color: grey">(e3e42ba)</span></li>
<li>staging/kde4support/tests/ktextbrowsertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110437/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>