Review Request 109667: Make some KConfig classes return a bool when saving

[Albert Astals Cid]

> On March 27, 2013, 7:27 a.m., Oswald Buddenhagen wrote:
> > tier2/kconfig/autotests/kconfigtest.cpp, line 1238
> > <http://git.reviewboard.kde.org/r/109667/diff/3/?file=122333#file122333line1238>
> >
> >     this actually has a good chance of failing on windows. you may need to restore the write permissions first.
> 
> Kevin Ottens wrote:
>     Albert, anything blocking you on this patch? It looked like it was on the right course to get in, only a small adjustment seems needed in the test as mentionned by Oswald.

Nothing blocking, just me needing time to finish the needed kconfig_compiler changes.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/#review29938
-----------------------------------------------------------


On March 26, 2013, 11:25 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109667/
> -----------------------------------------------------------
> 
> (Updated March 26, 2013, 11:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> If it can fail, i want to know it so i can tell my users
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html 7fbfa27 
>   tier2/kconfig/autotests/kconfigguitest.cpp e6b4c17 
>   tier2/kconfig/autotests/kconfigtest.h 17a5294 
>   tier2/kconfig/autotests/kconfigtest.cpp 86ff718 
>   tier2/kconfig/autotests/ksharedconfigtest.cpp 2bb612f 
>   tier2/kconfig/src/core/kconfig.h 597330f 
>   tier2/kconfig/src/core/kconfig.cpp d26f941 
>   tier2/kconfig/src/core/kconfigbase.h ce190f3 
>   tier2/kconfig/src/core/kconfiggroup.h ff63afa 
>   tier2/kconfig/src/core/kconfiggroup.cpp 53cac13 
>   tier2/kconfig/src/core/kcoreconfigskeleton.h 3e4971b 
>   tier2/kconfig/src/core/kcoreconfigskeleton.cpp c0ad044 
> 
> Diff: http://git.reviewboard.kde.org/r/109667/diff/
> 
> 
> Testing
> -------
> 
> New Unitttest passes
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130506/de3ea16a/attachment-0001.html>