<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109667/">http://git.reviewboard.kde.org/r/109667/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 27th, 2013, 7:27 a.m. UTC, <b>Oswald Buddenhagen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109667/diff/3/?file=122333#file122333line1238" style="color: black; font-weight: bold; text-decoration: underline;">tier2/kconfig/autotests/kconfigtest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1238</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QVERIFY</span><span class="p">(</span><span class="n">f</span><span class="p">.</span><span class="n">remove</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this actually has a good chance of failing on windows. you may need to restore the write permissions first.</pre>
</blockquote>
<p>On May 6th, 2013, 12:05 p.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Albert, anything blocking you on this patch? It looked like it was on the right course to get in, only a small adjustment seems needed in the test as mentionned by Oswald.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nothing blocking, just me needing time to finish the needed kconfig_compiler changes.</pre>
<br />
<p>- Albert</p>
<br />
<p>On March 26th, 2013, 11:25 p.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Oswald Buddenhagen.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated March 26, 2013, 11:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it can fail, i want to know it so i can tell my users</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New Unitttest passes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(7fbfa27)</span></li>
<li>tier2/kconfig/autotests/kconfigguitest.cpp <span style="color: grey">(e6b4c17)</span></li>
<li>tier2/kconfig/autotests/kconfigtest.h <span style="color: grey">(17a5294)</span></li>
<li>tier2/kconfig/autotests/kconfigtest.cpp <span style="color: grey">(86ff718)</span></li>
<li>tier2/kconfig/autotests/ksharedconfigtest.cpp <span style="color: grey">(2bb612f)</span></li>
<li>tier2/kconfig/src/core/kconfig.h <span style="color: grey">(597330f)</span></li>
<li>tier2/kconfig/src/core/kconfig.cpp <span style="color: grey">(d26f941)</span></li>
<li>tier2/kconfig/src/core/kconfigbase.h <span style="color: grey">(ce190f3)</span></li>
<li>tier2/kconfig/src/core/kconfiggroup.h <span style="color: grey">(ff63afa)</span></li>
<li>tier2/kconfig/src/core/kconfiggroup.cpp <span style="color: grey">(53cac13)</span></li>
<li>tier2/kconfig/src/core/kcoreconfigskeleton.h <span style="color: grey">(3e4971b)</span></li>
<li>tier2/kconfig/src/core/kcoreconfigskeleton.cpp <span style="color: grey">(c0ad044)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109667/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>