Review Request 109667: Make some KConfig classes return a bool when saving

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109667/
-----------------------------------------------------------

(Updated March 23, 2013, 3:47 p.m.)


Review request for KDE Frameworks and Oswald Buddenhagen.


Description
-------

If it can fail, i want to know it so i can tell my users

Not totally sure of the
   d->bDirty = true;
i added in 
   if (d->configState == ReadWrite && !tmp->lock()) {


Diffs (updated)
-----

  KDE5PORTING.html a01f3ec 
  tier2/kconfig/autotests/kconfigguitest.cpp e6b4c17 
  tier2/kconfig/autotests/kconfigtest.h 17a5294 
  tier2/kconfig/autotests/kconfigtest.cpp 86ff718 
  tier2/kconfig/autotests/ksharedconfigtest.cpp 2bb612f 
  tier2/kconfig/src/core/kconfig.h 597330f 
  tier2/kconfig/src/core/kconfig.cpp 5809275 
  tier2/kconfig/src/core/kconfigbase.h ce190f3 
  tier2/kconfig/src/core/kconfiggroup.h ff63afa 
  tier2/kconfig/src/core/kconfiggroup.cpp 53cac13 
  tier2/kconfig/src/core/kcoreconfigskeleton.h 3e4971b 
  tier2/kconfig/src/core/kcoreconfigskeleton.cpp c0ad044 

Diff: http://git.reviewboard.kde.org/r/109667/diff/


Testing
-------

New Unitttest passes


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130323/5100409e/attachment.html>