<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109667/">http://git.reviewboard.kde.org/r/109667/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Oswald Buddenhagen.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated March 23, 2013, 3:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it can fail, i want to know it so i can tell my users
Not totally sure of the
d->bDirty = true;
i added in
if (d->configState == ReadWrite && !tmp->lock()) {</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New Unitttest passes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(a01f3ec)</span></li>
<li>tier2/kconfig/autotests/kconfigguitest.cpp <span style="color: grey">(e6b4c17)</span></li>
<li>tier2/kconfig/autotests/kconfigtest.h <span style="color: grey">(17a5294)</span></li>
<li>tier2/kconfig/autotests/kconfigtest.cpp <span style="color: grey">(86ff718)</span></li>
<li>tier2/kconfig/autotests/ksharedconfigtest.cpp <span style="color: grey">(2bb612f)</span></li>
<li>tier2/kconfig/src/core/kconfig.h <span style="color: grey">(597330f)</span></li>
<li>tier2/kconfig/src/core/kconfig.cpp <span style="color: grey">(5809275)</span></li>
<li>tier2/kconfig/src/core/kconfigbase.h <span style="color: grey">(ce190f3)</span></li>
<li>tier2/kconfig/src/core/kconfiggroup.h <span style="color: grey">(ff63afa)</span></li>
<li>tier2/kconfig/src/core/kconfiggroup.cpp <span style="color: grey">(53cac13)</span></li>
<li>tier2/kconfig/src/core/kcoreconfigskeleton.h <span style="color: grey">(3e4971b)</span></li>
<li>tier2/kconfig/src/core/kcoreconfigskeleton.cpp <span style="color: grey">(c0ad044)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109667/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>