Review Request 109516: Deprecate NetAccess::dircopy

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109516/#review29330
-----------------------------------------------------------



kfile/kdiroperator.cpp
<http://git.reviewboard.kde.org/r/109516/#comment21915>

    This is wrong. The old code would not call mkdir if exists was true (short-circuit evaluation in A && B).
    You need if (!exists) { ... }



kfile/kdirselectdialog.cpp
<http://git.reviewboard.kde.org/r/109516/#comment21917>

    same here



kio/kio/netaccess.cpp
<http://git.reviewboard.kde.org/r/109516/#comment21916>

    You could just put all consecutive deprecated methods into the same #ifndef/#endif...


- David Faure


On March 16, 2013, 4:52 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109516/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 4:52 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Patch only adds KDE_NO_DEPRECATED to both NetAccess::dircopy methods and ports KEmoticonsProvider away from it.
> 
> I was wondering if I should mark as deprecated some other static methods such file_copy.
> 
> 
> Diffs
> -----
> 
>   kfile/kdiroperator.cpp 0bcc956 
>   kfile/kdirselectdialog.cpp 62fafec 
>   kio/kio/netaccess.h 3119c74 
>   kio/kio/netaccess.cpp fd50caa 
>   kross/ui/plugin.cpp 70a32af 
>   staging/kemoticons/src/core/kemoticonsprovider.cpp de073d8 
> 
> Diff: http://git.reviewboard.kde.org/r/109516/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130316/62c38807/attachment-0001.html>