Review Request 109516: Deprecate NetAccess::dircopy

Àlex Fiestas afiestas at kde.org
Sat Mar 16 16:52:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109516/
-----------------------------------------------------------

(Updated March 16, 2013, 4:52 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Deprecated NetAccess::del/mkdir/file_copy
Updated description from already deprecated method to recommend job+ui()->setWindow+job->exec
Removed uses of the new deprecated methods in frameworks.


Description
-------

Patch only adds KDE_NO_DEPRECATED to both NetAccess::dircopy methods and ports KEmoticonsProvider away from it.

I was wondering if I should mark as deprecated some other static methods such file_copy.


Diffs (updated)
-----

  kfile/kdiroperator.cpp 0bcc956 
  kfile/kdirselectdialog.cpp 62fafec 
  kio/kio/netaccess.h 3119c74 
  kio/kio/netaccess.cpp fd50caa 
  kross/ui/plugin.cpp 70a32af 
  staging/kemoticons/src/core/kemoticonsprovider.cpp de073d8 

Diff: http://git.reviewboard.kde.org/r/109516/diff/


Testing
-------


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130316/c559ab0f/attachment.html>


More information about the Kde-frameworks-devel mailing list