QLineEdit and QComboBox tasks

[Albert Vaca]

Hello Kevin,

As you say, a search on lxr reveals that it is used in 4 places. Of
those, 2 are already KUrlRequesters. To avoid breaking the other 2, we
can keep the property in KLineEdit and KComboBox (that will be in
KDE4Support), even though I think it would be better for those to use
KUrlRequester (they are actually requesting urls!).

I think this is a conservative enough solution and I have opened a
review board for the patch [1].

Although, my original idea was to remove this feature from KLineEdit
since I find no reason in having a url-related property in a general
purpose KLineEdit, when we already have KUrlRequester.

[1] https://git.reviewboard.kde.org/r/111184/

Regards,
Albert Vaca

On Mon, Jun 24, 2013 at 11:26 AM, Kevin Ottens
<ervin+bluesystems at kde.org> wrote:
> Hello,
>
> On Saturday 22 June 2013 17:34:41 Albert Vaca wrote:
>> There are two tasks in Qt5 Epics [1] to implement replace-on-drop for
>> URLs on QLineEdit and QComboBox. This is currently present in
>> KLineEdit and KComboBox, because this behaviour is needed for
>> KUrlRequester (bug [2]).
>>
>> We (aacid, apol and me) have been discussing about it and we think
>> that this behaviour should be implemented using installEventFilter()
>> on KUrlRequester. This way KUrlRequester could be implemented using a
>> standard QComboBox without need to patch Qt.
>>
>> If you agree, I will close those two tasks for Qt and implement this
>> feature using installEventFilter() in KUrlRequester.
>
> Well lxr claims it's not only used by KUrlRequester. It doesn't have many uses
> though... So I agree with your proposal to make it an event filter *if* said
> event filter is done in a way that it can be used with KUrlRequester,
> QComboBox and QLineEdit (means it'd need its own class). It also would have to
> be made a public class in either KGuiAddons or KWidgetsAddons.
>
> Regards.
> --
> Kévin Ottens, http://ervin.ipsquad.net
>
> Sponsored by BlueSystems and KDAB to work on KDE Frameworks
>
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>