QLineEdit and QComboBox tasks

[Kevin Ottens]

Hello,

On Tuesday 25 June 2013 00:17:24 Albert Vaca wrote:
> As you say, a search on lxr reveals that it is used in 4 places. Of
> those, 2 are already KUrlRequesters. To avoid breaking the other 2, we
> can keep the property in KLineEdit and KComboBox (that will be in
> KDE4Support), even though I think it would be better for those to use
> KUrlRequester (they are actually requesting urls!).

Fair enough.

For the 2 uses which are not KUrlRequester one is actually just disabling the 
feature so it'd be better off with a simple QLineEdit already. The other one 
in rekonq is probably right in not using KUrlRequester as it does something 
really different.

My only "concern" is that the feature is enabled by default... Which means 
that looking for the calls to the set as we did won't tell us the whole story. 
That said, I doubt much that it matters to the user that dropping an URL in a 
random line edit has to replace instead of insert... it really only makes 
sense in "url bars".

> I think this is a conservative enough solution and I have opened a
> review board for the patch [1].
> 
> Although, my original idea was to remove this feature from KLineEdit
> since I find no reason in having a url-related property in a general
> purpose KLineEdit, when we already have KUrlRequester.

Well, we try to be as source compatible as possible so we can't really remove 
it. You could mark it deprecated though.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by BlueSystems and KDAB to work on KDE Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130625/ffd5a171/attachment.sig>