Review Request 111232: move klineedit and kcompletionbox to KCompletion framework
Kevin Ottens
ervin at kde.org
Thu Jun 27 15:00:57 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111232/#review35172
-----------------------------------------------------------
kdeui/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111232/#comment25749>
I think you misunderstood me, the point was to leave KdeUiWidgetsProxyStyle in untouched in kdeui. But just to port away KLineEdit from it.
kdeui/widgets/klineedit.cpp
<http://git.reviewboard.kde.org/r/111232/#comment25750>
That logic appears twice, couldn't it be factored in KLineEditStyle constructor?
kdeui/widgets/klineedit.cpp
<http://git.reviewboard.kde.org/r/111232/#comment25751>
Second occurrence of the logic I mentionned above.
khtml/rendering/render_form.h
<http://git.reviewboard.kde.org/r/111232/#comment25752>
All the changes of that file should be in a separate patch.
khtml/rendering/render_form.cpp
<http://git.reviewboard.kde.org/r/111232/#comment25753>
All the changes of that file should be in a separate patch (with the changes on render_form.h).
- Kevin Ottens
On June 26, 2013, 11:38 a.m., Wojciech Kapuscinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111232/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 11:38 a.m.)
>
>
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
>
>
> Description
> -------
>
> move klineedit and kcompletionbox to KCompletion framework
>
> Notes:
> KIconTheme::assignIconsToContextMenu( KIconTheme::TextEditor, popup->actions () ) removed because there is task in Qt5 Epics (Add icons to QLineEdit context menu (via qstyle?)).
>
> Can we cut dependency do KIconThemes too?
>
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt 3946ebf
> kdeui/tests/CMakeLists.txt 2dd4079
> kdeui/tests/klineedit_unittest.cpp
> kdeui/tests/klineedittest.h
> kdeui/tests/klineedittest.cpp
> kdeui/widgets/kcompletionbox.h 6e10dcf
> kdeui/widgets/kcompletionbox.cpp
> kdeui/widgets/kdeuiwidgetsproxystyle.cpp b1d1403
> kdeui/widgets/kdeuiwidgetsproxystyle_p.h 91f4958
> kdeui/widgets/klineedit.h 7ac22f6
> kdeui/widgets/klineedit.cpp 24920a8
> kdeui/widgets/klineedit_p.h 7c58f2d
> kfile/CMakeLists.txt bc48bf7
> khtml/rendering/render_form.h cfd23d8
> khtml/rendering/render_form.cpp ad2a20b
> kioslave/http/kcookiejar/CMakeLists.txt 2dae665
> knewstuff/knewstuff3/CMakeLists.txt 41ea203
> kross/ui/CMakeLists.txt 65e1abb
> kutils/CMakeLists.txt bfe8541
> security/crypto/CMakeLists.txt e890d33
> staging/kcompletion/autotests/CMakeLists.txt f497c9a
> staging/kcompletion/src/CMakeLists.txt e502554
> staging/kcompletion/src/config-kcompletion.h.cmake PRE-CREATION
> staging/kcompletion/tests/CMakeLists.txt e8e39f3
> staging/kde4attic/src/CMakeLists.txt 0cf1be7
> staging/kde4support/src/CMakeLists.txt 551181c
> staging/kemoticons/tests/CMakeLists.txt 3c59e7e
>
> Diff: http://git.reviewboard.kde.org/r/111232/diff/
>
>
> Testing
> -------
>
> it builds
>
>
> Thanks,
>
> Wojciech Kapuscinski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130627/93f5c532/attachment.html>
More information about the Kde-frameworks-devel
mailing list