<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111232/">http://git.reviewboard.kde.org/r/111232/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111232/diff/3/?file=165845#file165845line129" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">widgets/kdeuiwidgetsproxystyle.cpp</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you misunderstood me, the point was to leave KdeUiWidgetsProxyStyle in untouched in kdeui. But just to port away KLineEdit from it.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111232/diff/3/?file=165855#file165855line274" style="color: black; font-weight: bold; text-decoration: underline;">staging/kcompletion/src/klineedit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KLineEdit::initWidget()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">271</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">style</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KLineEditStyle</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">270</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="k">this</span><span class="o">-></span><span class="n">parentWidget</span><span class="p">()</span> <span class="p">){</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That logic appears twice, couldn't it be factored in KLineEditStyle constructor?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111232/diff/3/?file=165855#file165855line1388" style="color: black; font-weight: bold; text-decoration: underline;">staging/kcompletion/src/klineedit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KLineEdit::event( QEvent* ev )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1381</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">style</span> <span class="o">=</span> <span class="n">kleStyle</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KLineEditStyle</span><span class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1382</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="k">this</span><span class="o">-></span><span class="n">parentWidget</span><span class="p">()){</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Second occurrence of the logic I mentionned above.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111232/diff/3/?file=165858#file165858line43" style="color: black; font-weight: bold; text-decoration: underline;">khtml/rendering/render_form.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class QWidget;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <QProxyStyle></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the changes of that file should be in a separate patch.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111232/diff/3/?file=165859#file165859line46" style="color: black; font-weight: bold; text-decoration: underline;">khtml/rendering/render_form.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <kdeuiwidgetsproxystyle_p.h></span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the changes of that file should be in a separate patch (with the changes on render_form.h).</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On June 26th, 2013, 11:38 a.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated June 26, 2013, 11:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move klineedit and kcompletionbox to KCompletion framework
Notes:
KIconTheme::assignIconsToContextMenu( KIconTheme::TextEditor, popup->actions () ) removed because there is task in Qt5 Epics (Add icons to QLineEdit context menu (via qstyle?)).
Can we cut dependency do KIconThemes too?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(3946ebf)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(2dd4079)</span></li>
<li>kdeui/tests/klineedit_unittest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/klineedittest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/klineedittest.cpp <span style="color: grey">()</span></li>
<li>kdeui/widgets/kcompletionbox.h <span style="color: grey">(6e10dcf)</span></li>
<li>kdeui/widgets/kcompletionbox.cpp <span style="color: grey">()</span></li>
<li>kdeui/widgets/kdeuiwidgetsproxystyle.cpp <span style="color: grey">(b1d1403)</span></li>
<li>kdeui/widgets/kdeuiwidgetsproxystyle_p.h <span style="color: grey">(91f4958)</span></li>
<li>kdeui/widgets/klineedit.h <span style="color: grey">(7ac22f6)</span></li>
<li>kdeui/widgets/klineedit.cpp <span style="color: grey">(24920a8)</span></li>
<li>kdeui/widgets/klineedit_p.h <span style="color: grey">(7c58f2d)</span></li>
<li>kfile/CMakeLists.txt <span style="color: grey">(bc48bf7)</span></li>
<li>khtml/rendering/render_form.h <span style="color: grey">(cfd23d8)</span></li>
<li>khtml/rendering/render_form.cpp <span style="color: grey">(ad2a20b)</span></li>
<li>kioslave/http/kcookiejar/CMakeLists.txt <span style="color: grey">(2dae665)</span></li>
<li>knewstuff/knewstuff3/CMakeLists.txt <span style="color: grey">(41ea203)</span></li>
<li>kross/ui/CMakeLists.txt <span style="color: grey">(65e1abb)</span></li>
<li>kutils/CMakeLists.txt <span style="color: grey">(bfe8541)</span></li>
<li>security/crypto/CMakeLists.txt <span style="color: grey">(e890d33)</span></li>
<li>staging/kcompletion/autotests/CMakeLists.txt <span style="color: grey">(f497c9a)</span></li>
<li>staging/kcompletion/src/CMakeLists.txt <span style="color: grey">(e502554)</span></li>
<li>staging/kcompletion/src/config-kcompletion.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kcompletion/tests/CMakeLists.txt <span style="color: grey">(e8e39f3)</span></li>
<li>staging/kde4attic/src/CMakeLists.txt <span style="color: grey">(0cf1be7)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(551181c)</span></li>
<li>staging/kemoticons/tests/CMakeLists.txt <span style="color: grey">(3c59e7e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111232/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>