Review Request 110988: Port kio-file to QFile

Martin Klapetek martin.klapetek at gmail.com
Tue Jun 25 20:08:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/
-----------------------------------------------------------

(Updated June 25, 2013, 8:08 p.m.)


Review request for KDE Frameworks.


Changes
-------

Updated as per comments. 

I'm unable to run the tests (even without this patch), the job operations fail with error 143 (with errorString being "The process for the file protocol died unexpectedly."), I'm not sure what's the cause. Thoughts?


Description
-------

Ports away kioslave/file from unix/kde specific calls to QFile calls


Diffs (updated)
-----

  kioslave/file/file.h 93aeef4 
  kioslave/file/file.cpp 6b8b268 
  kioslave/file/file_unix.cpp 8b92e06 

Diff: http://git.reviewboard.kde.org/r/110988/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130625/96b7a1f9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list