Review Request 110988: Port kio-file to QFile
Martin Klapetek
martin.klapetek at gmail.com
Mon Jun 24 13:52:43 UTC 2013
> On June 21, 2013, 7:44 a.m., David Faure wrote:
> > Did you upload the same patch as before? The issues are still there (e.g. if (!write))
>
> Martin Klapetek wrote:
> I haven't updated it yet, will do so today.
>
> Kevin Ottens wrote:
> Today as in three days ago? ;)
Fwiw, I wanted to update my environment before updating this and got stucked with build error with Qt5, turned out it was linking against my system sql libs. Then I had problems building frameworks so I just gave up for the weekend. I actually still can't successfully build latest frameworks, but I'll contact you guys outside this review.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review34807
-----------------------------------------------------------
On June 19, 2013, 1:04 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110988/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 1:04 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Ports away kioslave/file from unix/kde specific calls to QFile calls
>
>
> Diffs
> -----
>
> kioslave/file/file.h 93aeef4
> kioslave/file/file.cpp d57517b
> kioslave/file/file_unix.cpp 8b92e06
>
> Diff: http://git.reviewboard.kde.org/r/110988/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130624/d0beaa1b/attachment.html>
More information about the Kde-frameworks-devel
mailing list