Review Request 110988: Port kio-file to QFile
David Faure
faure at kde.org
Thu Jun 20 08:42:27 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review34736
-----------------------------------------------------------
kioslave/file/file.cpp
<http://git.reviewboard.kde.org/r/110988/#comment25467>
Forget my comment about write_all, not needed. The if() is still wrong though, it should compare the retval with data.size().
kioslave/file/file.cpp
<http://git.reviewboard.kde.org/r/110988/#comment25465>
check error() != NoError, rather than checking isOpen(), says Ossi. Close will always close, so isOpen isn't a good measure for errors.
kioslave/file/file_unix.cpp
<http://git.reviewboard.kde.org/r/110988/#comment25466>
I was wrong, QFile does have the loop (in QFSFileEnginePrivate::writeFdFh). So this line is correct, and write_all isn't needed.
- David Faure
On June 19, 2013, 1:04 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110988/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 1:04 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Ports away kioslave/file from unix/kde specific calls to QFile calls
>
>
> Diffs
> -----
>
> kioslave/file/file.h 93aeef4
> kioslave/file/file.cpp d57517b
> kioslave/file/file_unix.cpp 8b92e06
>
> Diff: http://git.reviewboard.kde.org/r/110988/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130620/0b86c64d/attachment.html>
More information about the Kde-frameworks-devel
mailing list