Review Request 110988: Port kio-file to QFile

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review34671
-----------------------------------------------------------



kioslave/file/file.cpp
<http://git.reviewboard.kde.org/r/110988/#comment25453>

    if (!res.isEmpty())



kioslave/file/file.cpp
<http://git.reviewboard.kde.org/r/110988/#comment25454>

    Wrong, write doesn't return a bool, it returns an int, the number of bytes written.
    
    The loop from write_all might still be necessary (except the handling of EINTR, that's done internally in Qt).



kioslave/file/file_unix.cpp
<http://git.reviewboard.kde.org/r/110988/#comment25464>

    Same issue here; the old code would retry if necessary.


- David Faure


On June 19, 2013, 1:04 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110988/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 1:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Ports away kioslave/file from unix/kde specific calls to QFile calls
> 
> 
> Diffs
> -----
> 
>   kioslave/file/file.h 93aeef4 
>   kioslave/file/file.cpp d57517b 
>   kioslave/file/file_unix.cpp 8b92e06 
> 
> Diff: http://git.reviewboard.kde.org/r/110988/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130620/1407558c/attachment.html>