Review Request 111105: Create KWallet framework and move kwallet.h and others

[Kevin Ottens]

> On June 19, 2013, 1:26 a.m., Wojciech Kapuscinski wrote:
> > hmmm strange. kwallettest is unit test but was in manual tests (CMakeLists.txt in kdeui).
> > Not sure what to do because kwallettest requires kwalletd
> 
> Valentin Rusu wrote:
>     Perhaps we could use this kdeui splitting opportunity to bring here kwalletd from kdeutils. We could end-up with a standalone framework, in respect to KF5 aim, IMHO.

Yes, that's something to be done when we split the repos. It'll be the right time to pull runtime dependencies like that.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111105/#review34636
-----------------------------------------------------------


On June 19, 2013, 9:49 a.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111105/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 9:49 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Create KWallet framework and move kwallet.h and others.
> 
> Notes:
> Port aways from kdebug
> remove unused includes
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 0f2a0a9 
>   kdeui/tests/CMakeLists.txt 482581c 
>   kdeui/tests/kwallettest.h  
>   kdeui/tests/kwallettest.cpp 7a91a29 
>   kdeui/util/config-kwallet.h.cmake  
>   kdeui/util/kwallet.h eb46a89 
>   kdeui/util/kwallet.cpp 7016b51 
>   kdeui/util/kwallet_mac.cpp ce09f93 
>   kdeui/util/org.kde.KWallet.xml  
>   kdewebkit/CMakeLists.txt 93a44e9 
>   khtml/CMakeLists.txt 010eb95 
>   kio/CMakeLists.txt a29905e 
>   staging/CMakeLists.txt 4e4132b 
>   staging/kwallet/CMakeLists.txt PRE-CREATION 
>   staging/kwallet/KWalletConfig.cmake.in PRE-CREATION 
>   staging/kwallet/autotests/CMakeLists.txt PRE-CREATION 
>   staging/kwallet/src/CMakeLists.txt PRE-CREATION 
>   staging/kwallet/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111105/diff/
> 
> 
> Testing
> -------
> 
> It builds on Linux.
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130620/084b6c63/attachment.html>