<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111105/">http://git.reviewboard.kde.org/r/111105/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 19th, 2013, 1:26 a.m. UTC, <b>Wojciech Kapuscinski</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmmm strange. kwallettest is unit test but was in manual tests (CMakeLists.txt in kdeui).
Not sure what to do because kwallettest requires kwalletd</pre>
</blockquote>
<p>On June 19th, 2013, 4:58 p.m. UTC, <b>Valentin Rusu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Perhaps we could use this kdeui splitting opportunity to bring here kwalletd from kdeutils. We could end-up with a standalone framework, in respect to KF5 aim, IMHO.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, that's something to be done when we split the repos. It'll be the right time to pull runtime dependencies like that.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On June 19th, 2013, 9:49 a.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated June 19, 2013, 9:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create KWallet framework and move kwallet.h and others.
Notes:
Port aways from kdebug
remove unused includes
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds on Linux.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(0f2a0a9)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(482581c)</span></li>
<li>kdeui/tests/kwallettest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kwallettest.cpp <span style="color: grey">(7a91a29)</span></li>
<li>kdeui/util/config-kwallet.h.cmake <span style="color: grey">()</span></li>
<li>kdeui/util/kwallet.h <span style="color: grey">(eb46a89)</span></li>
<li>kdeui/util/kwallet.cpp <span style="color: grey">(7016b51)</span></li>
<li>kdeui/util/kwallet_mac.cpp <span style="color: grey">(ce09f93)</span></li>
<li>kdeui/util/org.kde.KWallet.xml <span style="color: grey">()</span></li>
<li>kdewebkit/CMakeLists.txt <span style="color: grey">(93a44e9)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(010eb95)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(a29905e)</span></li>
<li>staging/CMakeLists.txt <span style="color: grey">(4e4132b)</span></li>
<li>staging/kwallet/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwallet/KWalletConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwallet/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwallet/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kwallet/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111105/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>