KGlobalSettings move to kde4support

[Kevin Ottens]

On Thursday 20 June 2013 07:50:04 Martin Gräßlin wrote:
> On Wednesday 19 June 2013 15:04:57 Matthew Woehlke wrote:
> > On 2013-06-18 11:54, Aleix Pol wrote:
> > > On Tue, Jun 18, 2013 at 5:40 PM, Matthew Woehlke wrote:
> > >> On 2013-06-18 03:10, Dominik Haumann wrote:
> > >>> On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote:
> > >>>> On Monday 17 June 2013 19:43:33 Aleix Pol wrote:
> > >>>>> So I was looking at KGlobalSettings to see what we need to do to
> > >>>>> finally
> > >>>>> deprecate all KGlobalSettings, as suggested by the required kdelibs
> > >>>>> cleanups.
> > >>>>> 
> > >>>>> So the things missing to be done are:
> > >>>>>    - (in)active(Title/Color)Color: I'm unsure why those are there,
> > >>>>>    but
> > >>>>> 
> > >>>>> they're only used by khtml (within kdelibs) and I don't know if
> > >>>>> they're
> > >>>>> configurable. I guess they should be using KColorScheme, although I
> > >>>>> don't see caption properties there. Ideas?
> > >> 
> > >> What are these used for? They sound like WM colors?
> > >> 
> > >>   It's used a bit outside of kdelibs, but not much indeed. Still as you
> > >>   said
> > >>   
> > >>>> it likely makes most sense in KColorScheme. So I'd say extend
> > >>>> KColorScheme
> > >>>> accordingly and then deprecate.
> > >> 
> > >> Perhaps, but KColorScheme already has quite some colors and they are
> > >> (fairly) well organized at the moment. I would like to understand first
> > >> what these other colors are used for and if maybe existing colors
> > >> should
> > >> be
> > >> used instead, or at least how to best fit them into the existing
> > >> framework.
> > > 
> > > Here you can see where and how it's used:
> > > 
> > > http://lxr.kde.org/ident?i=activeTitleColor
> > > http://lxr.kde.org/ident?i=inactiveTitleColor
> > > http://lxr.kde.org/ident?i=activeCaptionColor
> > > http://lxr.kde.org/ident?i=inactiveCaptionColor
> > 
> > Yes, those appear to be the WM colors.
> 
> I just had a look at the usage of KGlobalSettings inside KWin: none of these
> colors are used - neither in KWin core nor in the window decorations
> shipped with KWin. KWin reads color values with these names from a config
> group called "WM" without using KGlobalSettings (see kde-
> workspace/kwin/libkdecorations/kdecoration_p.cpp line 60ff). But tracing
> back the argument passed into this method: it always reads the values from
> kwinrc, never from kdeglobals. In case that had once been supported: it's
> at least broken since 4.0.
> 
> So from my side there is no need to keep any special handling. If we want to
> make this work again we just need to modify the KCM to change kwin's config
> file for these colors.

Right... So that means the pair of usages we have in khtml are kind of abuse 
from the original intent. I'd say we port those to KColorScheme calls instead 
and that's it, no further action required (I adjusted the wiki in that 
regard).

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by BlueSystems and KDAB to work on KDE Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130620/06283ced/attachment.sig>