Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

[Kevin Ottens]

> On June 14, 2013, 6:59 a.m., Kevin Ottens wrote:
> > staging/kconfigwidgets/src/kviewstatemaintainer.h, line 25
> > <http://git.reviewboard.kde.org/r/111002/diff/1/?file=150267#file150267line25>
> >
> >     Should be kconfigwidgets_export.h ... I even suspect this line could go completely.
> 
> Wojciech Kapuscinski wrote:
>     Yes. It should be kconfigwidgets_export.h. 
>     Why we should remove this include? KViewStateMaintainer is used by kdepim (lxr). We should add KCONFIGWIDGETS_EXPORT to KViewStateMaintainer in my opinion.

Well it includes kviewstatemaintainerbase.h which in turn includes kconfigwidgets_export.h. So including kviewstatemaintainerbase.h only should be enough.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111002/#review34334
-----------------------------------------------------------


On June 13, 2013, 6:12 p.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111002/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 6:12 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> simple move 
> 
> Note.
> KViewStateSaver is typedef. lxr says that only one class use KViewStateSaver. Remove this kviewstatesaver.h header?
> 
> 
> Diffs
> -----
> 
>   staging/kconfigwidgets/src/kviewstatesaver.h PRE-CREATION 
>   staging/kconfigwidgets/src/kviewstatemaintainer.cpp PRE-CREATION 
>   staging/kconfigwidgets/src/kviewstatemaintainer.h PRE-CREATION 
>   staging/kconfigwidgets/src/CMakeLists.txt 534b95d 
>   kdeui/itemviews/kviewstatesaver.h 4384974 
>   kdeui/itemviews/kviewstatemaintainer.cpp cb788ed 
>   kdeui/itemviews/kviewstatemaintainer.h 5ae9797 
>   kdeui/CMakeLists.txt 46196b4 
> 
> Diff: http://git.reviewboard.kde.org/r/111002/diff/
> 
> 
> Testing
> -------
> 
> it builds and tests all OK
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130617/b9717ce6/attachment.html>