<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111002/">http://git.reviewboard.kde.org/r/111002/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 14th, 2013, 6:59 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111002/diff/1/?file=150267#file150267line25" style="color: black; font-weight: bold; text-decoration: underline;">staging/kconfigwidgets/src/kviewstatemaintainer.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "kdeui_export.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should be kconfigwidgets_export.h ... I even suspect this line could go completely.</pre>
</blockquote>
<p>On June 17th, 2013, 12:35 p.m. UTC, <b>Wojciech Kapuscinski</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. It should be kconfigwidgets_export.h.
Why we should remove this include? KViewStateMaintainer is used by kdepim (lxr). We should add KCONFIGWIDGETS_EXPORT to KViewStateMaintainer in my opinion.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well it includes kviewstatemaintainerbase.h which in turn includes kconfigwidgets_export.h. So including kviewstatemaintainerbase.h only should be enough.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On June 13th, 2013, 6:12 p.m. UTC, Wojciech Kapuscinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Wojciech Kapuscinski.</div>
<p style="color: grey;"><i>Updated June 13, 2013, 6:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">simple move
Note.
KViewStateSaver is typedef. lxr says that only one class use KViewStateSaver. Remove this kviewstatesaver.h header?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it builds and tests all OK</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kconfigwidgets/src/kviewstatesaver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kconfigwidgets/src/kviewstatemaintainer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kconfigwidgets/src/kviewstatemaintainer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kconfigwidgets/src/CMakeLists.txt <span style="color: grey">(534b95d)</span></li>
<li>kdeui/itemviews/kviewstatesaver.h <span style="color: grey">(4384974)</span></li>
<li>kdeui/itemviews/kviewstatemaintainer.cpp <span style="color: grey">(cb788ed)</span></li>
<li>kdeui/itemviews/kviewstatemaintainer.h <span style="color: grey">(5ae9797)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(46196b4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111002/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>