Review Request 111028: Move kkeyserver* to KWindowsSystem

Kevin Ottens ervin at kde.org
Mon Jun 17 10:02:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111028/#review34471
-----------------------------------------------------------



kdeui/util/kkeyserver.cpp
<http://git.reviewboard.kde.org/r/111028/#comment25301>

    Don't use QObject::tr, use QApplication::translate instead, probably using "KKeyServer" for the context parameter.


- Kevin Ottens


On June 14, 2013, 7:30 p.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111028/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move kkeyserver* to KWindowsSystem
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 05401a7 
>   kdeui/util/kkeyserver.h 4676eae 
>   kdeui/util/kkeyserver.cpp a7853eb 
>   kdeui/util/kkeyserver_mac.h 2910f88 
>   kdeui/util/kkeyserver_mac.cpp 2f3a496 
>   kdeui/util/kkeyserver_win.h d1457eb 
>   kdeui/util/kkeyserver_win.cpp a02c5b9 
>   kdeui/util/kkeyserver_x11.h da48d6d 
>   kdeui/util/kkeyserver_x11.cpp 4f74821 
>   tier1/kwindowsystem/src/CMakeLists.txt b191830 
> 
> Diff: http://git.reviewboard.kde.org/r/111028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Port
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130617/8225ab23/attachment.html>


More information about the Kde-frameworks-devel mailing list