<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111028/">http://git.reviewboard.kde.org/r/111028/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111028/diff/1/?file=150455#file150455line62" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kwindowsystem/src/kkeyserver.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static ModInfo g_rgModInfo[4] =</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">g_rgModInfo</span><span class="p">[</span><span class="mi">0</span><span class="p">].</span><span class="n">sLabel</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QString</span><span class="p">(</span><span class="hl"> </span><span class="n"><span class="hl">i18nc</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">KEYCTXT</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n">g_rgModInfo</span><span class="p">[</span><span class="mi">0</span><span class="p">].</span><span class="n">psName</span><span class="p">)</span><span class="hl"> </span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">g_rgModInfo</span><span class="p">[</span><span class="mi">0</span><span class="p">].</span><span class="n">sLabel</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QString</span><span class="p">(</span><span class="n"><span class="hl">QObject</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">tr</span></span><span class="p"><span class="hl">((</span></span><span class="n">g_rgModInfo</span><span class="p">[</span><span class="mi">0</span><span class="p">].</span><span class="n">psName</span><span class="p">)<span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">KEYCTXT</span></span><span class="p"><span class="hl">)</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't use QObject::tr, use QApplication::translate instead, probably using "KKeyServer" for the context parameter.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On June 14th, 2013, 7:30 p.m. UTC, Benjamin Port wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Benjamin Port.</div>
<p style="color: grey;"><i>Updated June 14, 2013, 7:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move kkeyserver* to KWindowsSystem</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(05401a7)</span></li>
<li>kdeui/util/kkeyserver.h <span style="color: grey">(4676eae)</span></li>
<li>kdeui/util/kkeyserver.cpp <span style="color: grey">(a7853eb)</span></li>
<li>kdeui/util/kkeyserver_mac.h <span style="color: grey">(2910f88)</span></li>
<li>kdeui/util/kkeyserver_mac.cpp <span style="color: grey">(2f3a496)</span></li>
<li>kdeui/util/kkeyserver_win.h <span style="color: grey">(d1457eb)</span></li>
<li>kdeui/util/kkeyserver_win.cpp <span style="color: grey">(a02c5b9)</span></li>
<li>kdeui/util/kkeyserver_x11.h <span style="color: grey">(da48d6d)</span></li>
<li>kdeui/util/kkeyserver_x11.cpp <span style="color: grey">(4f74821)</span></li>
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(b191830)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111028/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>