Review Request 110957: fix compilation with clang

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110957/#review34159
-----------------------------------------------------------



staging/kde4support/src/kdecore/kgenericfactory.h
<http://git.reviewboard.kde.org/r/110957/#comment25075>

    Ouch, I really wonder how this compiled with gcc.... it makes little sense, since there's no such constructor anymore, indeed.
    
    However the fix loses information (the rest of the about data fields). To fix that, in the constructor code, add
    
    KAboutData::registerPluginData(*data);
    
    About the QString-utf8-QString roundtrip, I guess that's fine for a deprecated class.



tier1/threadweaver/benchmarks/QueueBenchmarks.cpp
<http://git.reviewboard.kde.org/r/110957/#comment25076>

    reviewboard detects something weird about the indentation... did you use tabs? spaces only please.


- David Faure


On June 11, 2013, 4:05 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110957/
> -----------------------------------------------------------
> 
> (Updated June 11, 2013, 4:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Fix compilation with clang
> 
> Not sure about the kgenericfactory.h change, though: it converts QString -> Utf8 -> QString.
> Maybe add another constructor to KPluginFactory that takes two QStrings?
> 
> 
> Diffs
> -----
> 
>   kdeui/tests/kcolorbuttontest.cpp 81e659f78199ffe98d6f0b6a9b46506e11a999a2 
>   staging/kde4support/src/kdecore/kgenericfactory.h 6e9279e8b0d543a1edd8e948b21284e37dbe5a83 
>   tier1/threadweaver/benchmarks/QueueBenchmarks.cpp 9324f641612f8c9536b01ff2befb3d9d9fb12c75 
> 
> Diff: http://git.reviewboard.kde.org/r/110957/diff/
> 
> 
> Testing
> -------
> 
> compiles now
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130611/a52e80e5/attachment.html>