Review Request 110957: fix compilation with clang
Alexander Richardson
arichardson.kde at googlemail.com
Tue Jun 11 16:05:34 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110957/
-----------------------------------------------------------
Review request for KDE Frameworks.
Description
-------
Fix compilation with clang
Not sure about the kgenericfactory.h change, though: it converts QString -> Utf8 -> QString.
Maybe add another constructor to KPluginFactory that takes two QStrings?
Diffs
-----
kdeui/tests/kcolorbuttontest.cpp 81e659f78199ffe98d6f0b6a9b46506e11a999a2
staging/kde4support/src/kdecore/kgenericfactory.h 6e9279e8b0d543a1edd8e948b21284e37dbe5a83
tier1/threadweaver/benchmarks/QueueBenchmarks.cpp 9324f641612f8c9536b01ff2befb3d9d9fb12c75
Diff: http://git.reviewboard.kde.org/r/110957/diff/
Testing
-------
compiles now
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130611/ee4987ac/attachment.html>
More information about the Kde-frameworks-devel
mailing list