Review Request 110418: Move KNumInput to KDE4Support

[David Faure]

> On June 3, 2013, 10:18 a.m., David Faure wrote:
> > kdeui/dialogs/kconfigdialogmanager.cpp, line 146
> > <http://git.reviewboard.kde.org/r/110418/diff/2/?file=146814#file146814line146>
> >
> >     OK, first step is a unittest. Can you confirm that your commit breaks this test?
> >     http://www.davidfaure.fr/2013/kconfigdialog_unittest_numinput.diff
> >     (it passes for me, with unmodified frameworks branch)
> >     
> >     Oh, and you didn't see it, but the class documentation for KConfigDialogManager actually explains how to register a custom class from the outside.
> >     
> >     So something like this should fix it, please test:
> >     
> >     KConfigDialogManager::changedMap()->insert("KIntNumInput", SIGNAL(valueChanged(int)));
> >     
> >
> 
> Anne-Marie Mahfouf wrote:
>     The test passes but outputs "QDEBUG : KConfigDialog_UnitTest::test() Don't know how to monitor widget ' KIntNumInput ' for changes!
>     "
>     while when KConfigDialogManager::changedMap()->insert("KIntNumInput", SIGNAL(valueChanged(int))); is added in KNumInput constructor the widget is monitored (and the test still passes)
>

I tested your patch, it works fine. I cannot confirm the QDEBUG you saw. I think you forgot to "make install" on the library before testing (and the RPATH problems made it not pick the local lib, possibly).

If it works after make install, feel free to commit.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/#review33632
-----------------------------------------------------------


On June 8, 2013, 1:44 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110418/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 1:44 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Move KNumInput to KDE4Support, use QSpinBox or QDoubleSpinBox instead.
> Test moved as well.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 3302cc0 
>   kdeui/dialogs/kconfigdialogmanager.cpp 87c3e48 
>   kdeui/dialogs/kinputdialog.cpp dfe2493 
>   kdeui/dialogs/kinputdialog_p.h dcdff3f 
>   kdeui/tests/CMakeLists.txt 7ffc47a 
>   kdeui/tests/kconfigdialog_unittest.cpp 4f1a7a7 
>   kdeui/tests/knuminputtest.h 5c41e28 
>   kdeui/tests/knuminputtest.cpp 6387337 
>   kdeui/tests/krulertest.h fc677c6 
>   kdeui/tests/krulertest.cpp 9686421 
>   kdeui/widgets/knuminput.h 06d1ebd 
>   kdeui/widgets/knuminput.cpp 8a288a5 
>   kdewidgets/kde.widgets 877be5c 
>   kdewidgets/kdedeprecated.qrc 699df9e 
>   kdewidgets/kdedeprecated.widgets c560777 
>   kdewidgets/kdewidgets.qrc 06873eb 
>   staging/kde4support/src/CMakeLists.txt 1f6edde 
>   staging/kde4support/src/kdeui/kcolordialog.cpp 041c06a 
>   staging/kde4support/src/kdeui/knuminput.h PRE-CREATION 
>   staging/kde4support/src/kdeui/knuminput.cpp PRE-CREATION 
>   staging/kde4support/tests/CMakeLists.txt 6f3632b 
>   staging/kde4support/tests/knuminputtest.h PRE-CREATION 
>   staging/kde4support/tests/knuminputtest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110418/diff/
> 
> 
> Testing
> -------
> 
> Build tested
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130610/cfc96e4d/attachment.html>