<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110418/">http://git.reviewboard.kde.org/r/110418/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 3rd, 2013, 10:18 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110418/diff/2/?file=146814#file146814line146" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/dialogs/kconfigdialogmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KConfigDialogManager::initMaps()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">146</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">s_changedMap</span><span class="p">()</span><span class="o">-></span><span class="n">insert</span><span class="p">(</span> <span class="s">"KIntNumInput"</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">valueChanged</span><span class="p">(</span><span class="kt">int</span><span class="p">)));</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, first step is a unittest. Can you confirm that your commit breaks this test?
http://www.davidfaure.fr/2013/kconfigdialog_unittest_numinput.diff
(it passes for me, with unmodified frameworks branch)
Oh, and you didn't see it, but the class documentation for KConfigDialogManager actually explains how to register a custom class from the outside.
So something like this should fix it, please test:
KConfigDialogManager::changedMap()->insert("KIntNumInput", SIGNAL(valueChanged(int)));
</pre>
</blockquote>
<p>On June 8th, 2013, 1:18 p.m. UTC, <b>Anne-Marie Mahfouf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The test passes but outputs "QDEBUG : KConfigDialog_UnitTest::test() Don't know how to monitor widget ' KIntNumInput ' for changes!
"
while when KConfigDialogManager::changedMap()->insert("KIntNumInput", SIGNAL(valueChanged(int))); is added in KNumInput constructor the widget is monitored (and the test still passes)
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested your patch, it works fine. I cannot confirm the QDEBUG you saw. I think you forgot to "make install" on the library before testing (and the RPATH problems made it not pick the local lib, possibly).
If it works after make install, feel free to commit.</pre>
<br />
<p>- David</p>
<br />
<p>On June 8th, 2013, 1:44 p.m. UTC, Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Kevin Ottens.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated June 8, 2013, 1:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move KNumInput to KDE4Support, use QSpinBox or QDoubleSpinBox instead.
Test moved as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build tested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(3302cc0)</span></li>
<li>kdeui/dialogs/kconfigdialogmanager.cpp <span style="color: grey">(87c3e48)</span></li>
<li>kdeui/dialogs/kinputdialog.cpp <span style="color: grey">(dfe2493)</span></li>
<li>kdeui/dialogs/kinputdialog_p.h <span style="color: grey">(dcdff3f)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(7ffc47a)</span></li>
<li>kdeui/tests/kconfigdialog_unittest.cpp <span style="color: grey">(4f1a7a7)</span></li>
<li>kdeui/tests/knuminputtest.h <span style="color: grey">(5c41e28)</span></li>
<li>kdeui/tests/knuminputtest.cpp <span style="color: grey">(6387337)</span></li>
<li>kdeui/tests/krulertest.h <span style="color: grey">(fc677c6)</span></li>
<li>kdeui/tests/krulertest.cpp <span style="color: grey">(9686421)</span></li>
<li>kdeui/widgets/knuminput.h <span style="color: grey">(06d1ebd)</span></li>
<li>kdeui/widgets/knuminput.cpp <span style="color: grey">(8a288a5)</span></li>
<li>kdewidgets/kde.widgets <span style="color: grey">(877be5c)</span></li>
<li>kdewidgets/kdedeprecated.qrc <span style="color: grey">(699df9e)</span></li>
<li>kdewidgets/kdedeprecated.widgets <span style="color: grey">(c560777)</span></li>
<li>kdewidgets/kdewidgets.qrc <span style="color: grey">(06873eb)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(1f6edde)</span></li>
<li>staging/kde4support/src/kdeui/kcolordialog.cpp <span style="color: grey">(041c06a)</span></li>
<li>staging/kde4support/src/kdeui/knuminput.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/src/kdeui/knuminput.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/tests/CMakeLists.txt <span style="color: grey">(6f3632b)</span></li>
<li>staging/kde4support/tests/knuminputtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>staging/kde4support/tests/knuminputtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110418/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>